Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/eslint #41

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Refactor/eslint #41

wants to merge 9 commits into from

Conversation

Gijsdeman
Copy link
Contributor

Description

Moves eslint to @gewis/eslint-config-typescript. This introduces quite some issues, as this config uses type information for more accurate code.

Since there are so many changes to be made, it is probably best to work through this file by file, getting rid of all the errors in separate commits and squash this later.

Types of changes

  • Refactoring (Changes that neither fixes a bug nor adds a feature)

@Gijsdeman Gijsdeman changed the base branch from master to main February 25, 2025 13:23
@Gijsdeman Gijsdeman self-assigned this Feb 25, 2025
@Gijsdeman Gijsdeman mentioned this pull request Feb 25, 2025
Open
@Gijsdeman Gijsdeman added the help wanted Extra attention is needed label Feb 25, 2025
@Gijsdeman Gijsdeman force-pushed the refactor/eslint branch 2 times, most recently from 25b34f0 to c9b8c46 Compare February 26, 2025 21:27
@Gijsdeman
Copy link
Contributor Author

Gijsdeman commented Feb 26, 2025 •
edited
Loading

Fixed eslint issues wherever possible. However, some files need a bigger overhaul to resolve the remaining issues:

  • FileService.ts: needs some more generics
  • ActivityService.ts: needs some more generics
  • rawQueries.ts: needs to be rewritten to use query builders
  • activity.ts: has some generics that didn't work out, need to take another look
  • filters.ts: not sure if it is still required with new typeorm updates

I will leave these for separate issues, however, and this can be merged to at least move to newer version of eslint.

@Gijsdeman Gijsdeman marked this pull request as ready for review February 26, 2025 21:50
@Gijsdeman Gijsdeman removed the help wanted Extra attention is needed label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoronex Yoronex Awaiting requested review from Yoronex

@LuukBlankenstijn LuukBlankenstijn Awaiting requested review from LuukBlankenstijn

Assignees

@Gijsdeman Gijsdeman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gijsdeman